-
Couldn't load subscription status.
- Fork 5.2k
Implement SVE2 ConvertToSingleOdd and ConvertToSingleRoundToOdd #118957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement SVE2 ConvertToSingleOdd and ConvertToSingleRoundToOdd #118957
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some failures in CI to look at: console log.
Ok thanks, understood. #119201 is also waiting, but that one is a new group (scatters), and there will be a follow on to PR to finish the group. So if we can't get both the scatters into .NET 10, then it'll be better to leave those two until 11. |
|
@SwapnilGaikwad Can you resolve the merge conflicts that have arisen please? |
Done. |
|
Hi @jeffhandley, what can we do to push this PR further? I'll rebase it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some minor changes. The changes look similar to previous changes so they seem good to me but @tannergooding should take a look too.
|
@tannergooding, this is ready to review. |
|
#118380 is pending on this PR. |
|
@SwapnilGaikwad once you address the feedback from Tanner, our team will do another pass of review. |
Co-authored-by: Tanner Gooding <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi @JulieLeeMSFT , the failures seem unrelated to this PR (they are x64 only and changes are SVE only). It is now ready for another pass of review. |
|
@EgorBo, PTAL. |
Contributes to #94018
@dotnet/arm64-contrib @amanasifkhalid @a74nh
Co-authored-by: @jacob-crawley